fix(transformer/class-properties): private_field_count is incorrect when class only have accessor with private field#10463
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 17, 2025
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10463 will not alter performanceComparing Summary
|
overlookmotel
approved these changes
Apr 17, 2025
Member
Merge activity
|
… when class only have `accessor` with private field (#10463) ```ts abstract class Foo { accessor prop: number = 1; static accessor prop2: number = 1; accessor #prop3: number = 1; accessor [prop4]: number = 1; private accessor prop5: number = 1; abstract accessor prop6: number; } ``` This case only has a `#prop3` private field with an accessor. Since we haven't supported transforming `accessor` yet, the `class_details.is_transform_required` is always `false` in this `class`, which caused the `private_field_count` to be incorrect. Moving the decremental part to the `pop` side so that we can make sure the `private_props_prop` can always be handled correctly.
graphite-app
bot
force-pushed
the
04-17-fix_transformer_class-properties_private_field_count_is_incorrect_when_class_only_have_accessor_with_private_field
branch
from
bf23a8a to
45f8cc0
Compare
graphite-app
bot
deleted the
04-17-fix_transformer_class-properties_private_field_count_is_incorrect_when_class_only_have_accessor_with_private_field
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This case only has a
#prop3private field with an accessor. Since we haven't supported transformingaccessoryet, theclass_details.is_transform_requiredis alwaysfalsein thisclass, which caused theprivate_field_countto be incorrect. Moving the decremental part to thepopside so that we can make sure theprivate_props_propcan always be handled correctly.